Skip to content

No need to set stl feature#187

Merged
jwillemsen merged 2 commits intoRemedyIT:masterfrom
jwillemsen:jwi-stlzap
Dec 8, 2025
Merged

No need to set stl feature#187
jwillemsen merged 2 commits intoRemedyIT:masterfrom
jwillemsen:jwi-stlzap

Conversation

@jwillemsen
Copy link
Member

@jwillemsen jwillemsen commented Dec 8, 2025 •
edited by coderabbitai bot
Loading 

* brix11/lib/brix11/brix/common/cmds/configure/hostsetup.rb:

Summary by CodeRabbit

  • Build Configuration
    • Streamlined the host build configuration by reducing the default set of enabled features, resulting in a more focused and consistent build setup.

✏️ Tip: You can customize this high-level summary in your review settings.

@jwillemsen
No need to set stl feature
9d35f22 
    * brix11/lib/brix11/brix/common/cmds/configure/hostsetup.rb:
@jwillemsen
Merge branch 'master' into jwi-stlzap
3d11508
@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025 •
edited
Loading

Walkthrough

Removed the stl=1 feature flag from the default_features configuration block in the host build setup, reducing the set of automatically enabled features for the host build configuration.

Changes

Cohort / File(s) Change Summary
Host build configuration
brix11/lib/brix11/brix/common/cmds/configure/hostsetup.rb		 Removed stl=1 line from default_features in create_build_config method

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A feature stripped, configuration lean,
STL goes away, the config's clean,
Less to build, more to gain,
Simplicity flows through the main!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and concisely describes the main change: removing the stl feature default setting from the host build configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1af96c1 and 3d11508.

📒 Files selected for processing (1)
  • brix11/lib/brix11/brix/common/cmds/configure/hostsetup.rb (0 hunks)
💤 Files with no reviewable changes (1)
  • brix11/lib/brix11/brix/common/cmds/configure/hostsetup.rb
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: windows-2025 ruby-3.1 vs2022 --release
  • GitHub Check: windows-2025 ruby-2.6 vs2022 --release
  • GitHub Check: windows-2025 ruby-3.1 vs2022 --debug
  • GitHub Check: ubuntu-22.04 g++-9 ruby-2.5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen jwillemsen merged commit 2b7c3e6 into RemedyIT:master Dec 8, 2025
11 of 20 checks passed
@jwillemsen jwillemsen deleted the jwi-stlzap branch December 8, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jwillemsen